Home Forums Wiki Doc Install Extras Screenshots Source Code Projects Blog Users Groups Register
Glx-Dock / Cairo-Dock List of forums Git Version | Version Git Huge modifications on BZR :)
The latest stable release is the *3.4.0* : How to install it here.
Note: We just switched from BZR to Git on Github! (only to host the code and your future pull requests)
Git Version | Version Git
Subjects Author Language Messages Last message
[Locked] Huge modifications on BZR :)
Page : 1 2
matttbe English 38 matttbe [Read]
11 September 2013 à 22:46

matttbe, Monday 20 May 2013 à 11:08

Subscription date : 24 January 2009
Messages : 12573 		Hello,

@fabounet: thank you for all these modifications

A lot of things to read and to test

I've just committed and pushed a few modifications to fix 2 compilation errors (can you have a look to the rev: 2808 ) and one thing was missing on X-manager (only details compared to all your modifications ).

I've not read and test all things but I'm a bit busy, I'll do that later

Just to not forget, I propose to report all new regressions here:
  • When launching the dock, I have white-grey rectangles back above the dock during less than 1/2 second. I guess it's linked to the container.c (the workaround with the opacity).
  • (it's not a regression due to these last changes but due to changes in 3.1.99 beta ) When the taskbar is on the extremity and when modifying the first/last icon (e.g. by adding/removing an new icon or by adding a new icon in the 'stack' of the first/last icon), the background move to the left during 1/10 second => bg_topic.php?t=6826
  • (I'm not sure that it's due to the last modifications) I've set a custom dimension in the config panel but this dimension is lower than expected (maybe because the dimension is also reduced by the 'scale' parameter of the panel view.)
  • MP is not fully drawn.

http://uppix.net/8/6/a/9946204f64dea2a61cc1498fcf00a.png
E.g. with Global menu on the top: what we have and what we should have bellow

http://uppix.net/7/8/0/394933619a81962c187d1b0759d8e.png
MP when the player is not started

fabounet, Tuesday 21 May 2013 à 14:46

Subscription date : 30 November 2007
Messages : 17118 		thanks for the tests
I can confirm 1 & 4 already
and yes, it was quite huge, and it's not even finished

matttbe, Tuesday 21 May 2013 à 20:41

Subscription date : 24 January 2009
Messages : 12573 		There is maybe a typo in gldit/cairo-dock-dialog-manager.c:997
        if (CAIRO_DOCK_IS_DOCK (pContainer))
        gtk_window_set_modal (GTK_WINDOW (pDialog->container.pWidget), TRUE);  // Note: there is a bug in Ubuntu version of GTK: gtkscrolledwindow in dialog breaks his modality (http://www.gtkforums.com/viewtopic.php?f=3&t=55727, LP: https://bugs.launchpad.net/ubuntu/+source/overlay-scrollbar/+bug/903302).
        {
            CAIRO_DOCK (pContainer)->bHasModalWindow = TRUE;
            cairo_dock_emit_enter_signal (pContainer);  // to prevent the dock from hiding. We want to see it until the dialog is visible (a leave event will be emited when it disappears).
        }

matttbe, Thursday 23 May 2013 à 01:07

Subscription date : 24 January 2009
Messages : 12573 		I just fixed the bug with white-grey rectangles at init, I pull just before doing a new commit and... a new rev is downloaded: committed 1 minute ago which also fixes this bug

EDIT: but a commit is missing in cairo-dock-plug-ins (it's no longer possible to compile these plugins). I can modify them but I guess you already did these changes.

EDIT 2: in src/gldit/cairo-dock-dock-manager.c, no need to add gtk_widget_show_all, it's already done in gldi_dock_init_internals.

fabounet, Thursday 23 May 2013 à 14:02

Subscription date : 30 November 2007
Messages : 17118
There is maybe a typo in gldit/cairo-dock-dialog-manager.c:997

indeed, thanks

yep sorry I forgot to push the plug-ins yesterday night (and remembered that when I woke up, maybe I had a nightmare about that )

matttbe, Thursday 23 May 2013 à 15:39

Subscription date : 24 January 2009
Messages : 12573 		fabounet :
yep sorry I forgot to push the plug-ins yesterday night (and remembered that when I woke up, maybe I had a nightmare about that )
Thank you!

matttbe, Monday 27 May 2013 à 14:28

Subscription date : 24 January 2009
Messages : 12573 		Also, it seems Global Menu does no longer track windows correctly.
If I launch the dock, the current window is correct until I switch to another window (we can see the icon of the previous window and the decoration of the current window (if it's maximised) is not removed)

matttbe, Monday 27 May 2013 à 16:16

Subscription date : 24 January 2009
Messages : 12573 		Another bug: my subdocks are opened when the mouse's pointer is over but I also have this bug when they are opened when clicking on the icon.
If the pointer is not immediately moved to the subdock when it's opening, then this subdock'll be closed just after the animation.


fabounet, Monday 27 May 2013 à 17:28

Subscription date : 30 November 2007
Messages : 17118 		ok thank you
I didn't notice the bug with the sub-dock, although I use the Shortcuts applet with the Slide view
do you have it with any view ?

matttbe, Monday 27 May 2013 à 19:01

Subscription date : 24 January 2009
Messages : 12573 		Yes, with all views BUT only when this applet is on the panel view and on the left

ppmt, Tuesday 28 May 2013 à 02:52

Subscription date : 29 November 2007
Messages : 3520 		Not sure if it is related to the global menu but I have noticed that even without the control of the windows is erratic

I don't normally use the global menu but recently I noticed that sometime if I minimise a window it won't work
the windows act as if it did minimise but it didn't. It has lost its focus and the only to recover it is click its icons in the dock
a couple of time

I tried to make a video but of course right now I can't reproduce

matttbe, Tuesday 28 May 2013 à 12:08

Subscription date : 24 January 2009
Messages : 12573 		I don't think it's linked to Global Menu bug but you can try because this bug is now fixed on BZR => rev 2818.

I don't regularly minimise my windows, so I can't confirm this bug.

@fabounet: I think I can update the 'weekly ppa'. What do you think about that?

fabounet, Friday 07 June 2013 à 16:40

Subscription date : 30 November 2007
Messages : 17118 		I still have some things to push (this WE I hope), so let's wait for next week

matttbe, Friday 07 June 2013 à 16:46

Subscription date : 24 January 2009
Messages : 12573 		(too late but it's working fine )

matttbe, Sunday 23 June 2013 à 21:08

Subscription date : 24 January 2009
Messages : 12573 		A short summary of all bugs listed here above:
  • When launching the dock, I have white-grey rectangles back above the dock during less than 1/2 second. I guess it's linked to the container.c (the workaround with the opacity). => it's better but I still see a tiny rectangle at startup (the size of one icon?)
  • (it's not a regression due to these last changes but due to changes in 3.1.99 beta ) When the taskbar is on the extremity and when modifying the first/last icon (e.g. by adding/removing an new icon or by adding a new icon in the 'stack' of the first/last icon), the background move to the left during 1/10 second => bg_topic.php?t=6826 => It seems to be fixed
  • (I'm not sure that it's due to the last modifications) I've set a custom dimension in the config panel but this dimension is lower than expected (maybe because the dimension is also reduced by the 'scale' parameter of the panel view.) => I still have this tiny problem but it's currently only a problem with Global-Menu.
  • MP is not fully drawn. => fixed!
  • Another bug: my subdocks are opened when the mouse's pointer is over but I also have this bug when they are opened when clicking on the icon. If the pointer is not immediately moved to the subdock when it's opening, then this subdock'll be closed just after the animation.
  • Rainbow view with a few icons (e.g. with Shortcuts applet) doesn't draw all icons: (here, all bookmarks are not drawn - and labels are not visible but this bug has been reported on another topic)

http://uppix.com/f-Capture_du_2013_51c743ac00133087.png

fabounet, Tuesday 25 June 2013 à 17:49

Subscription date : 30 November 2007
Messages : 17118 		thank you

it's better but I still see a tiny rectangle at startup (the size of one icon?)

it's strange because I don't see what's different from before
I notice it on sub-docks (not main docks) the first time they appear, but I don't remember if it was already the case before (I'll check that)

If the pointer is not immediately moved to the subdock when it's opening, then this subdock'll be closed just after the animation.

I don't seem to have it, does the sub-dock closes itself if you just let the mouse over the main icon ?

matttbe, Tuesday 25 June 2013 à 17:51

Subscription date : 24 January 2009
Messages : 12573
if it was already the case before (I'll check that)
I think yes (but maybe only when the computer was doing many other things or when copying a lot of files)

EDIT
I don't seem to have it, does the sub-dock closes itself if you just let the mouse over the main icon ?
Yes. But I only have this bug if shortcuts is on the top left.

fabounet, Tuesday 02 July 2013 à 17:33

Subscription date : 30 November 2007
Messages : 17118 		still don't have it
do we receive a leave event from X or something ?

matttbe, Tuesday 02 July 2013 à 21:50

Subscription date : 24 January 2009
Messages : 12573 		This is what I have when the mouse's pointer is above Shortcuts' icon
debug   :  (/opt/cairo-dock_bzr/cairo-dock-core/src/gldit/cairo-dock-dock-facility.c:cairo_dock_show_subdock:1005)  
  on montre le dock fils
message :  (/opt/cairo-dock_bzr/cairo-dock-core/src/implementations/cairo-dock-X-manager.c:_on_update_applis_list:260)  
   cette fenetre (23068706) de la pile n est pas dans la liste
debug   :  (/opt/cairo-dock_bzr/cairo-dock-core/src/gldit/cairo-dock-X-utilities.c:cairo_dock_xwindow_is_fullscreen_or_hidden_or_maximized:1371)  
  this appli should not be in taskbar anymore
debug   :  (/opt/cairo-dock_bzr/cairo-dock-core/src/implementations/cairo-dock-X-manager.c:_make_new_actor:138)  
  a shy window
message :  (/opt/cairo-dock_bzr/cairo-dock-plug-ins/icon-effect/src/applet-notifications.c:cd_icon_effect_free_data:319)  
  
message :  (/opt/cairo-dock_bzr/cairo-dock-core/src/implementations/cairo-dock-X-manager.c:_remove_old_applis:230)  
  cette fenetre (23068706, 0x33dd5e0, (null)) est trop vieille (6 / 7)
message :  (/opt/cairo-dock_bzr/cairo-dock-plug-ins/icon-effect/src/applet-notifications.c:cd_icon_effect_free_data:319) 


Did you try with Default-Panel theme with shortcuts on the top left?

If I uncomment all g_print in dock-factory.c in _on_leave_notify and _on_enter_notify, this is what I have
_on_enter_notify (bIsMainDock : 0; bInside:0; state:1; iMagnitudeIndex:0; input shape:21475b0; event:0x2d09540)
+++ input shape active on enter
_on_leave_notify (bInside:1; iState:0; iRefCount:0)
leave event: 54;12; 54;10; 0; 3
not really outside (54;12 ; 46/26)
start checking mouse
mouse: 54;12
_on_enter_notify (bIsMainDock : 0; bInside:0; state:0; iMagnitudeIndex:0; input shape:0; event:0x2d094b0)
_on_leave_notify (bInside:1; iState:0; iRefCount:1)
leave event: 54;-14; 54;10; 0; 3
on retarde la sortie du sous-dock de 250ms
_on_enter_notify (bIsMainDock : 0; bInside:1; state:0; iMagnitudeIndex:1000; input shape:21475b0; event:0x2d09660)
stop checking mouse (enter)
_on_leave_notify (bInside:1; iState:0; iRefCount:1)
forced leave event: 54;-14


If I quickly move my mouse into the subdock, this is what I have:
  • Enter:
    _on_leave_notify (bInside:1; iState:0; iRefCount:0)
    leave event: 51;18; 51;16; 0; 3
    not really outside (51;18 ; 46/26)
    start checking mouse
    mouse: 51;18
    _on_enter_notify (bIsMainDock : 0; bInside:0; state:0; iMagnitudeIndex:0; input shape:0; event:0x275a5d0)
    _on_leave_notify (bInside:1; iState:0; iRefCount:1)
    leave event: 51;-8; 51;16; 0; 3
    on retarde la sortie du sous-dock de 250ms
    _on_enter_notify (bIsMainDock : 0; bInside:1; state:0; iMagnitudeIndex:1000; input shape:21475b0; event:0x275a660)
    stop checking mouse (enter)
    _on_leave_notify (bInside:1; iState:0; iRefCount:0)
    leave event: 58;28; 58;26; 0; 3
    leave event : 58,0;28,0 (1366x46)
    on retarde la sortie du dock de 330ms
    _on_enter_notify (bIsMainDock : 0; bInside:1; state:0; iMagnitudeIndex:800; input shape:0; event:0x275a660)
    _on_leave_notify (bInside:1; iState:0; iRefCount:0)
    forced leave event: 152;183
  • The mouse's pointer is in the subdock. Now it leaves it:
    _on_leave_notify (bInside:1; iState:0; iRefCount:1)
    leave event: 0;196; 0;220; 0; 0
    on retarde la sortie du sous-dock de 250ms
    _on_enter_notify (bIsMainDock : 0; bInside:1; state:0; iMagnitudeIndex:1000; input shape:0; event:0x275a660)
    _on_leave_notify (bInside:1; iState:0; iRefCount:1)
    leave event: 0;196; 0;220; 0; 0
    on retarde la sortie du sous-dock de 250ms
    _on_enter_notify (bIsMainDock : 0; bInside:1; state:0; iMagnitudeIndex:1000; input shape:0; event:0x275a660)
    _on_leave_notify (bInside:1; iState:0; iRefCount:1)
    leave event: 0;196; 0;220; 0; 0
    on retarde la sortie du sous-dock de 250ms
    _on_enter_notify (bIsMainDock : 0; bInside:1; state:0; iMagnitudeIndex:1000; input shape:0; event:0x275a660)
    _on_leave_notify (bInside:1; iState:0; iRefCount:1)
    leave event: 0;196; 0;220; 0; 0
    on retarde la sortie du sous-dock de 250ms
    _on_leave_notify (bInside:1; iState:0; iRefCount:1)
    forced leave event: 0;196
    _on_leave_notify (bInside:0; iState:0; iRefCount:0)
    forced leave event: 0;227

fabounet, Thursday 04 July 2013 à 17:44

Subscription date : 30 November 2007
Messages : 17118 		with this theme, I have it the very first time I click on the Shortcuts icon, but then it works ok

Git Version | Version Git
Subjects Author Language Messages Last message
[Locked] Huge modifications on BZR :)
Page : 1 2
matttbe English 38 matttbe [Read]
11 September 2013 à 22:46


Glx-Dock / Cairo-Dock List of forums Git Version | Version Git Huge modifications on BZR :) Top
Online users :

Powered by ElementSpeak © 2007 Adrien Pilleboue, 2009-2013 Matthieu Baerts.
Dock based on CSS Dock Menu (Ndesign) with jQuery. Icons by zgegball
Cairo-Dock is a free software under GNU-GPL3 licence. First stable version created by Fabounet.
Many thanks to TuxFamily for the web Hosting and Mav for the domain name.