Subscription date : 21 October 2012
Messages : 39
1/ Don't get gtk and gtk3 useflags.
Look how other Gentoo ebuilds do !
Either you choose to depend on gtk2 exclusive or gtk3 => A single use flag is necessary : gtk3
And then in your dependency list :
gtk3? ( x11-libs/gtk+:3 )
!gtk3? ( x11-libs/gtk+:2 )
And of course no need at all to force whatever REQUIRED_USE
I actually stole that part from other ebuilds that are in the official tree. Can't remember which through.
I still do not understand the need for force_gtk2
Simple: If you have both, gtk2 and gtk3 installed cmake will use gtk3 by default, no matter what your USE flags are. The force flag is in the cmake file for exactly that reason, so we use it.
Well... I cannot really understand why this is needed... anyway... this sort of instruction has nothing to do in an ebuild.
Check by running repoman full in your x11-misc/cairo-dock directory. I would be surprised it his happy.
Again: How do you handle USE flags? All other ebuilds for cairo-dock don't handle USE flags at all. They have some, but no matter to what you set them, cairo-dock will compile exactly the same (from what is installed, not what USE flags tell).
3/ About the same things with plugins. PLUS :
- What the hell are you unpacking by yourself in src_unpack ? If you need to fiddle the extra .1, fiddle it elsewhere (in SRC_URI for example)
- I really doubt that the gtk dependency is needed you know. Plugins already depends on core and you launch core, so, you'll load gtk.
- I'm unpacking there cause I'm not experienced with ebuilds and that seemed to be a good way to me. If I change SRC_URI I download a different file, which isn't what I want...
- Maybe, but it looks more nice and makes sure the user knows what he does/wants. [EDIT]Also other plugin ebuilds do the same. See media-plugins/audacious-plugins for example.[/EDIT]